build: Add release-ng-arm64-fips release target #46930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a release target to `build.assets/Makefile` to build the arm64-fips release. This was missed before because I erroneously assumed we stopped doing that due to rust build issues, but it was just that rdpclient was no longer part of the arm64-fips build, not that we abandoned that build altogether.
camscale
added
the
no-changelog
doggydogworld
approved these changes
Sep 26, 2024
capnspacehook
approved these changes
Sep 26, 2024
|
@camscale looks like this just waiting for additional approvals. If you get got those, we would appreciate having FIPs compliant ARM64 docker images. |
@rohithrrao This PR is for a new build method that is not yet in use. We already publish ARM64 fips images -public.ecr.aws/gravitational/teleport-ent-fips-distroless:16.4.3 was just published today and it contains AMD64 and ARM64 architectures. |
avatus
approved these changes
Oct 17, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
zmb3 and
fheinecke
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a release target to
build.assets/Makefileto build the arm64-fipsrelease. This was missed before because I erroneously assumed we stopped
doing that due to rust build issues, but it was just that rdpclient was
no longer part of the arm64-fips build, not that we abandoned that build
altogether.